Improve no match performance using a struct#60
Merged
jwoertink merged 2 commits intoluckyframework:mainfrom Feb 16, 2023
Merged
Improve no match performance using a struct#60jwoertink merged 2 commits intoluckyframework:mainfrom
jwoertink merged 2 commits intoluckyframework:mainfrom
Conversation
jwoertink
approved these changes
Feb 16, 2023
Member
jwoertink
left a comment
There was a problem hiding this comment.
Awesome! Great PR. Thanks 😄
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously in #55 the
Matchresult was converted from a class to a struct however theNoMatchcase was left as a class. I also added a case to the benchmark script for this case as previously it was only matches.Before
After