Merged
Conversation
It's immutable and one is created per route match. Benchmark is updated as follows: Before: router 541.14k ( 1.85µs) (± 3.28%) 2.02kB/op fastest After: router 594.45k ( 1.68µs) (± 1.06%) 1.83kB/op fastest
The benchmark times are updated as follows: Before: router 590.63k ( 1.69µs) (± 1.06%) 1.83kB/op fastest After: router 720.56k ( 1.39µs) (± 1.16%) 1.33kB/op fastest
Given that we are only looking for the ascii characters '/' and '%', and UTF-8 guarantees that these will always come as individual bytes in the beginning of a character, we can simply traverse the string by bytes. This avoids decoding UTF-8 and gives a small performance boost. Benchmark times are updated as follows: Before: router 720.56k ( 1.39µs) (± 1.16%) 1.33kB/op fastest After: router 767.78k ( 1.30µs) (± 3.48%) 1.33kB/op fastest
This should be safer, and it seems performance isn't affected.
matthewmcgarvey
approved these changes
Sep 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #54
The old benchmark time (check #54) was this:
Now it's this:
After this, it seems most of the time is spent creating the
paramsHash of each match, and creating strings for each segment. There might be a chance to useBytesfor each segment to avoid those allocations, but maybe it would be too much (the overall API would change a lot.) Then, maybe theparamsHash of a match could be lazily instantiated, but it might not be worth it if frameworks using the router will always put stuff in theparamsHash. So this is probably a good stopping point :-)