This repository was archived by the owner on Aug 19, 2024. It is now read-only.
implemented staking information syncing API#1778
Merged
jeongkyun-oh merged 3 commits intoklaytn:devfrom Feb 24, 2023
Merged
Conversation
773ae58 to
e0e71c3
Compare
e0e71c3 to
a14b479
Compare
blukat29
previously approved these changes
Feb 23, 2023
kjeom
reviewed
Feb 23, 2023
Closed
ian0371
previously approved these changes
Feb 23, 2023
7669591 to
75bd2a1
Compare
75bd2a1 to
89f285b
Compare
blukat29
approved these changes
Feb 24, 2023
Contributor
blukat29
left a comment
There was a problem hiding this comment.
Much clearer with ReadCanonicalHash separated and 'stakingInfoRecovery' renamed. Thanks.
kjeom
approved these changes
Feb 24, 2023
ian0371
approved these changes
Feb 24, 2023
aidan-kwon
approved these changes
Feb 24, 2023
nohkwak
reviewed
Feb 24, 2023
nohkwak
approved these changes
Feb 24, 2023
ethan-kr
approved these changes
Feb 24, 2023
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Staking information was stored in misc db after state-db migration was developed. It is possible not to retrieve staking information on some past blocks. This PR add an API to sync staking information from other peers to update staking information on misc db.
Since staking information won't be validated, it would fetch the data from trusted node given by node id. Also, the boundary was given as well so that only a few staking information can be retrieved in the boundary.
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...