Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

implemented staking information syncing API#1778

Merged
jeongkyun-oh merged 3 commits intoklaytn:devfrom
jeongkyun-oh:230213-impl-sync-stakinginfo
Feb 24, 2023
Merged

implemented staking information syncing API#1778
jeongkyun-oh merged 3 commits intoklaytn:devfrom
jeongkyun-oh:230213-impl-sync-stakinginfo

Conversation

@jeongkyun-oh
Copy link
Contributor

Proposed changes

Staking information was stored in misc db after state-db migration was developed. It is possible not to retrieve staking information on some past blocks. This PR add an API to sync staking information from other peers to update staking information on misc db.

Since staking information won't be validated, it would fetch the data from trusted node given by node id. Also, the boundary was given as well so that only a few staking information can be retrieved in the boundary.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jeongkyun-oh jeongkyun-oh self-assigned this Feb 17, 2023
@jeongkyun-oh jeongkyun-oh force-pushed the 230213-impl-sync-stakinginfo branch 4 times, most recently from 773ae58 to e0e71c3 Compare February 17, 2023 04:45
@jeongkyun-oh jeongkyun-oh force-pushed the 230213-impl-sync-stakinginfo branch from e0e71c3 to a14b479 Compare February 20, 2023 15:46
@jeongkyun-oh jeongkyun-oh marked this pull request as ready for review February 21, 2023 00:07
@jeongkyun-oh jeongkyun-oh added the need to merge Need to merge for the next time label Feb 23, 2023
@blukat29 blukat29 added this to the v1.10.2 milestone Feb 23, 2023
blukat29
blukat29 previously approved these changes Feb 23, 2023
ian0371
ian0371 previously approved these changes Feb 23, 2023
@jeongkyun-oh jeongkyun-oh dismissed stale reviews from ian0371 and blukat29 via 7669591 February 23, 2023 15:47
@jeongkyun-oh jeongkyun-oh force-pushed the 230213-impl-sync-stakinginfo branch from 7669591 to 75bd2a1 Compare February 23, 2023 15:49
@jeongkyun-oh jeongkyun-oh force-pushed the 230213-impl-sync-stakinginfo branch from 75bd2a1 to 89f285b Compare February 23, 2023 15:51
Copy link
Contributor

@blukat29 blukat29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer with ReadCanonicalHash separated and 'stakingInfoRecovery' renamed. Thanks.

@jeongkyun-oh jeongkyun-oh requested a review from nohkwak February 24, 2023 03:17
@ethan-kr ethan-kr closed this Feb 24, 2023
@ethan-kr ethan-kr reopened this Feb 24, 2023
@jeongkyun-oh jeongkyun-oh merged commit 63248a5 into klaytn:dev Feb 24, 2023
@blukat29 blukat29 mentioned this pull request Mar 3, 2023
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

need to merge Need to merge for the next time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants