Move MITRE reference with external_id to the exterior level of the response for all MITRE endpoints#9144
Merged
davidjiglesias merged 10 commits intomasterfrom Jul 13, 2021
Merged
Conversation
3e63ea8 to
b63d9fb
Compare
CarlosRS9
reviewed
Jun 30, 2021
3995cdd to
31723ab
Compare
Co-authored-by: Carlos RS <54286452+CarlosRS9@users.noreply.github.com>
Co-authored-by: Carlos RS <54286452+CarlosRS9@users.noreply.github.com>
Co-authored-by: Carlos RS <54286452+CarlosRS9@users.noreply.github.com>
Co-authored-by: Carlos RS <54286452+CarlosRS9@users.noreply.github.com>
Co-authored-by: Carlos RS <54286452+CarlosRS9@users.noreply.github.com>
31723ab to
6d152b1
Compare
davidjiglesias
requested changes
Jul 8, 2021
Member
davidjiglesias
left a comment
There was a problem hiding this comment.
Add new references handling to father class
davidjiglesias
approved these changes
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team
This PR closes #8879.
In this pull request, I have included the reference with
external_idout of the references list of each MITRE item.I have updated unittest and API integration tests to include this change.
GET /mitre/mitigations?wait_for_complete=true&limit=1Response
With these changes, we can now sort by external_id, source and url:
GET /mitre/mitigations?wait_for_complete=true&limit=3&sort=-external_id&select=external_id,nameResponse
Test results:
Regards,
Manuel.