Skip to content

Change API examples in spec.yaml#8827

Merged
davidjiglesias merged 8 commits intomasterfrom
enhance/8801-review-body-examples-spec
Jun 14, 2021
Merged

Change API examples in spec.yaml#8827
davidjiglesias merged 8 commits intomasterfrom
enhance/8801-review-body-examples-spec

Conversation

@Espectro123
Copy link
Contributor

@Espectro123 Espectro123 commented May 27, 2021 •
edited
Loading

Related issue
#8801

Description

Hi team!

In this RP we have updated the examples of the endpoints that needed to be updated.

unchecked endpoints

/groups/{group_id}/configuration
/groups/{group_id}/files/{file_name}/json
/groups/{group_id}/files/{file_name}/xml
PUT /cluster/{node_id}/configuration
/cluster/{node_id}/configuration/{component}/{configuration}
PUT /lists/files/{filename}
/sca/{agent_id}/checks/{policy_id}
All experimental endpoints
/task/status

Typos detected

Endpoint: List security rules

user_name should be username

image

@Espectro123 Espectro123 self-assigned this May 27, 2021
@Espectro123 Espectro123 linked an issue May 27, 2021 that may be closed by this pull request
Review spec.yaml examples for all endpoints #8801
Closed
13 tasks
@mcarmona99 mcarmona99 self-assigned this Jun 7, 2021
@mcarmona99 mcarmona99 requested a review from davidjiglesias June 7, 2021 13:56
@mcarmona99 mcarmona99 force-pushed the enhance/8801-review-body-examples-spec branch from 2a59195 to a16eab2 Compare June 7, 2021 13:59
@mcarmona99 mcarmona99 marked this pull request as ready for review June 7, 2021 14:44
@mcarmona99 mcarmona99 mentioned this pull request Jun 8, 2021
Closed
13 tasks
@vicferpoy vicferpoy requested a review from Selutario June 11, 2021 08:47
Selutario
Selutario approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@Selutario Selutario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidjiglesias davidjiglesias merged commit ec55b36 into master Jun 14, 2021
@davidjiglesias davidjiglesias deleted the enhance/8801-review-body-examples-spec branch June 14, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidjiglesias davidjiglesias davidjiglesias approved these changes

+1 more reviewer

@Selutario Selutario Selutario approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Espectro123 Espectro123

@mcarmona99 mcarmona99

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Review spec.yaml examples for all endpoints

4 participants

@Espectro123 @Selutario @davidjiglesias @mcarmona99