Skip to content

Fix wrong alerts when file limit is reached#6802

Merged
vikman90 merged 3 commits intomasterfrom
5718-wrong-alert-when-reached-file-limit
Jan 13, 2021
Merged

Fix wrong alerts when file limit is reached#6802
vikman90 merged 3 commits intomasterfrom
5718-wrong-alert-when-reached-file-limit

Conversation

@antoniomanuelfr
Copy link

@antoniomanuelfr antoniomanuelfr commented Dec 2, 2020

Related issue
#5718

Description

This PR aims to fix the issue described in #5718 by adding a new SQLite query that gets the information of all the files in a specific folder.

Closes #5718

  • Compilation without warnings in every supported platform
    • Linux
    • Windows
    • MAC OS X
  • Source installation
  • Source upgrade
  • Review logs syntax and correct language
  • Memory tests for Linux
    • Scan-build report
    • Coverity
    • Valgrind (memcheck and descriptor leaks check)
  • Memory tests for Windows
    • Scan-build report
    • Coverity
    • Dr. Memory

@antoniomanuelfr antoniomanuelfr added the module/fim File Integrity Monitoring label Dec 2, 2020
@antoniomanuelfr antoniomanuelfr self-assigned this Dec 2, 2020
@jesusjimsa jesusjimsa self-requested a review December 9, 2020 10:09
@antoniomanuelfr antoniomanuelfr force-pushed the 5718-wrong-alert-when-reached-file-limit branch from 4ddae47 to 5b11578 Compare December 9, 2020 12:06
Copy link
Contributor

@jesusjimsa jesusjimsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antoniomanuelfr antoniomanuelfr force-pushed the 5718-wrong-alert-when-reached-file-limit branch from 5b11578 to baf6faa Compare December 11, 2020 07:32
@antoniomanuelfr antoniomanuelfr force-pushed the 5718-wrong-alert-when-reached-file-limit branch from baf6faa to 73230c6 Compare December 15, 2020 15:09
@antoniomanuelfr antoniomanuelfr marked this pull request as draft December 16, 2020 11:02
@antoniomanuelfr antoniomanuelfr marked this pull request as ready for review December 16, 2020 11:33
@jotacarma90 jotacarma90 self-requested a review December 17, 2020 13:53
Copy link
Contributor

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vikman90 vikman90 merged commit c5da7da into master Jan 13, 2021
@vikman90 vikman90 deleted the 5718-wrong-alert-when-reached-file-limit branch January 13, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/fim File Integrity Monitoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong alert when the file_limit is reached

5 participants