Merged
Conversation
vikman90
requested changes
Apr 4, 2018
Member
vikman90
left a comment
There was a problem hiding this comment.
The remote command switch option fix is awesome.
The wm_sendmsg() function call is very convenient.
But the timeout would prevent the command wodle from executing long term processes or even daemons (undefined duration processes).
If the command timeout is desirable, it should be a per-command option, and allow infinite timeout.
vikman90
approved these changes
Apr 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds several fixes for the Command module including the following:
Fix control when checking if the remote commands are allowed to be executed by agents when a command is configured in the
ossec.conf.Added a timeout to wait for the command output.
Send command output messages to the manager to the correct agent queue.