Cast pid_t to int at log printing to avoid compile warnings in Solaris 10#2121
Merged
chemamartinez merged 1 commit into3.8from Dec 17, 2018
Merged
Cast pid_t to int at log printing to avoid compile warnings in Solaris 10#2121chemamartinez merged 1 commit into3.8from
chemamartinez merged 1 commit into3.8from
Conversation
chemamartinez
approved these changes
Dec 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes issue #2120.
The compiler complains that
pid_tis notintin Solaris 10.According to the GNU C Library, the type
pid_tis a signed integer. Then, the closes standard C type isint.We propose to cast
pid_ttointwhen printing logs.