The CppCheck parser should retain the order of violations#195
Merged
tomasbjerre merged 1 commit intotomasbjerre:masterfrom Nov 15, 2025
Merged
The CppCheck parser should retain the order of violations#195tomasbjerre merged 1 commit intotomasbjerre:masterfrom
tomasbjerre merged 1 commit intotomasbjerre:masterfrom
Conversation
6 tasks
The CppCheck parser handels individual locations of a warning as separate violations. These violations are then returned to the caller as a sorted set, destroying the insertion order. To visualize the affected locations in the original order, we need to store the insertion order by adding a new property. See https://issues.jenkins.io/browse/JENKINS-75217
b2c7d20 to
f7b7216
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CppCheck parser handles individual locations of a warning as separate violations. These violations are then returned to the caller as a sorted set, destroying the insertion order. To visualize the affected locations in the original order, we need to store the insertion order by adding a new property.
See JENKINS-75217
Note: I first tried to replace the
TreeSetwith aLinkedHashSetbut this will destroy the ordering for all your parsers...