Skip to content

Add shift_{left,right} on slices#151812

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
scottmcm:slice-shift
Jan 31, 2026
Merged

Add shift_{left,right} on slices#151812
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
scottmcm:slice-shift

Conversation

@scottmcm
Copy link
Member

@scottmcm scottmcm commented Jan 29, 2026 •
edited
Loading

ACP approval: rust-lang/libs-team#717 (comment)
cc tracking issue #151772

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 29, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2026

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@scottmcm scottmcm mentioned this pull request Jan 29, 2026
Open
5 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@scottmcm
Add shift_{left,right} on slices
4264da6 
cc tracking issue 151772
@jhpratt
Copy link
Member

jhpratt commented Jan 31, 2026

While I find the name confusing, that's a team decision that I have no say over.

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 31, 2026

📌 Commit 4264da6 has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2026
@jhpratt jhpratt mentioned this pull request Jan 31, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 31, 2026
@bors
Auto merge of #151891 - jhpratt:rollup-cG0AjgK, r=jhpratt
1e9be1b 
Rollup of 5 pull requests

Successful merges:

 - #143650 (core: add Option::get_or_try_insert_with)
 - #151726 (Remove duplicated code in `slice/index.rs`)
 - #151812 (Add `shift_{left,right}` on slices)
 - #151829 (Implement `BinaryHeap::pop_if()`)
 - #151838 (Fix typo for Maybe dangling docs)
@rust-bors rust-bors bot merged commit 4e21b69 into rust-lang:main Jan 31, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 31, 2026
rust-timer added a commit that referenced this pull request Jan 31, 2026
@rust-timer
Unrolled build for #151812
d7fc781 
Rollup merge of #151812 - scottmcm:slice-shift, r=jhpratt

Add `shift_{left,right}` on slices

ACP approval: rust-lang/libs-team#717 (comment)
cc tracking issue #151772
@scottmcm scottmcm deleted the slice-shift branch January 31, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jhpratt jhpratt

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

4 participants

@scottmcm @rustbot @rust-log-analyzer @jhpratt