feat(oauth): determine OAuth flow from account definition instead of destination definition#6660
Closed
shekhar-rudder wants to merge 1 commit intomasterfrom
Closed
feat(oauth): determine OAuth flow from account definition instead of destination definition#6660shekhar-rudder wants to merge 1 commit intomasterfrom
shekhar-rudder wants to merge 1 commit intomasterfrom
Conversation
e50a0d9 to
d167b85
Compare
…destination definition
d167b85 to
f9bcb5e
Compare
|
This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthenticationTypeover destination definition configDeleteAccount/DeliveryAccount) through regulation-worker and router transformer pathsProblem
Currently, we rely on the destination definition to determine whether to use OAuth flow. However, for destinations using accounts, we should use the account definition since a destination can support both non-OAuth and OAuth accounts (e.g., basic auth vs OAuth).
Solution
Updated
IsOAuthDestinationto:Account.AccountDefinition.AuthenticationType == "oauth"definitionConfigauth type check only if account info is unavailableThis ensures proper OAuth flow selection based on the actual account configuration rather than the destination's general capabilities.
Linear Ticket
https://linear.app/rudderstack/issue/INT-5712/fix-oauth-detection-logic-in-rudder-server
Security