Revert "Do not handle declarations in modules without side effects as…#5654
Closed
skovhus wants to merge 1 commit intorollup:masterfrom
Closed
Revert "Do not handle declarations in modules without side effects as…#5654skovhus wants to merge 1 commit intorollup:masterfrom
skovhus wants to merge 1 commit intorollup:masterfrom
Conversation
… TDZ (rollup#5322)" This reverts commit ba1c2db.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
moduleSideEffects: falseremoves side effectful getter inside a exported function since 4.9.2 #5408Description
Revert #5322 that eliminates too much code.