Skip to content

Renamed initial health check policies and unhealthy database argument#3949

Merged
vladvildanov merged 5 commits intomasterfrom
vv-geofailover-api-fix
Feb 11, 2026
Merged

Renamed initial health check policies and unhealthy database argument#3949
vladvildanov merged 5 commits intomasterfrom
vv-geofailover-api-fix

Conversation

@vladvildanov
Copy link
Collaborator

@vladvildanov vladvildanov commented Feb 10, 2026

Description of change

Please provide a description of the change here.

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

@vladvildanov
Copy link
Collaborator Author

vladvildanov commented Feb 10, 2026

augment review

@augmentcode
Copy link

augmentcode bot commented Feb 10, 2026

🤖 Augment PR Summary

Summary: Renames MultiDB “initial health check” policies and the “unhealthy database” flag for clearer semantics.
Changes:

  • Renamed `InitialHealthCheck` members from `*_HEALTHY` to `*_AVAILABLE` (and updated the default policy).
  • Renamed `add_database` flag from `skip_unhealthy` to `allow_unhealthy` in both sync and asyncio clients.
  • Updated initial-health-check evaluation logic to use the new enum values.
  • Adjusted unit tests to reflect the new names.

🤖 Was this summary useful? React with 👍 or 👎

augmentcode[bot]
augmentcode bot reviewed Feb 10, 2026
View reviewed changes
Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 4 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

petyaslavova
petyaslavova approved these changes Feb 10, 2026
View reviewed changes
Copy link
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vladvildanov vladvildanov merged commit 24974fe into master Feb 11, 2026
63 checks passed
@vladvildanov vladvildanov deleted the vv-geofailover-api-fix branch February 11, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petyaslavova petyaslavova petyaslavova approved these changes

+1 more reviewer

@augmentcode augmentcode[bot] augmentcode[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vladvildanov @petyaslavova