fix(19325): properly set overlay as display none if blocked equals false#19439
Open
Cr3aHal0 wants to merge 1 commit intoprimefaces:masterfrom
Open
fix(19325): properly set overlay as display none if blocked equals false#19439Cr3aHal0 wants to merge 1 commit intoprimefaces:masterfrom
Cr3aHal0 wants to merge 1 commit intoprimefaces:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 19325
Disclaimer : As of today, PrimeNG implementation of BlockUI is quite different from PrimeVue & PrimeReact one which is unified (the component is a wrapper of content and the overlay is projected within the wrapper boundaries, whereas in PrimeNG BlockUi is much likely a sibling of the target to be blocked). I did not know if this component had any major plan coming from PrimeNG team, so I opted for a quick working fix which just makes sure that if the blocked flag is false at startup then it should consider the overlay as invisible (hence the display: none, which is already called when manually hiding the overlay and then prevents the overlay content to show in the first place - which was the description of the issue)