Switching to a central definition of dart-sass version#14691
Merged
melloware merged 4 commits intoprimefaces:masterfrom Feb 17, 2026
Merged
Switching to a central definition of dart-sass version#14691melloware merged 4 commits intoprimefaces:masterfrom
melloware merged 4 commits intoprimefaces:masterfrom
Conversation
Member
|
I thought I was on 1.79.1 as it's the last one that does not throw warnings and errors There is an open ticket about it. |
Member
|
Yep #13833 |
Contributor
Author
Thank you for your reply, but then it is even more important that this is defined on a central place. I switched the version to 1.79.6, which is named in #13833 |
melloware
approved these changes
Feb 17, 2026
Member
|
Thanks this is a good change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the version of dart‑sass is defined only in the primefaces-themes module, while primefaces-showcase uses no explicit version. This makes builds not necessarily reproducible across environments. In addition, some environments require offline availability, which is only possible when the dart‑sass version is pinned consistently.
This pull request introduces a centralized definition of the dart‑sass version and ensures that both primefaces-themes and primefaces-showcase use the same version. As part of this improvement, the dependency is set to the correct dart‑sass version (1.79.6, https://github.com/sass/dart-sass/releases) according to #13833.
I hope this change helps make the build process more stable, predictable, and contributor‑friendly. Looking forward to your feedback!