Skip to content

fix(components): type composeRenderProps callback in Button#7881

Open
themanjeetkr wants to merge 1 commit intoplone:mainfrom
themanjeetkr:fix/button-composeRenderProps-types
Open

fix(components): type composeRenderProps callback in Button#7881
themanjeetkr wants to merge 1 commit intoplone:mainfrom
themanjeetkr:fix/button-composeRenderProps-types

Conversation

@themanjeetkr
Copy link

@themanjeetkr themanjeetkr commented Feb 10, 2026

Caution

The Volto Team has suspended its review of new pull requests from first-time contributors until the release of Plone 7, which is preliminarily scheduled for the second quarter of 2026.
Read details.



If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #


If your pull request includes changes to the documentation—either in narrative documentation, Storybook, or configuration—then a pull request preview will be generated and a link will populate in the description of your pull request below.
By clicking that link, you can use the visual diff menu in the upper right corner to navigate to pages that have changes, then display the diff by checking the Show diff checkbox.

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 10, 2026

Caution

The Volto Team has suspended its review of new pull requests from first-time contributors until the release of Plone 7, which is preliminarily scheduled for the second quarter of 2026.
Read details.

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, read
Plone's Code of Conduct,
Contributing to Plone,
First-time contributors, and
Contributing to Volto,
as this will greatly help the review process.

Welcome to the Plone community! 🎉

@mister-roboto
Copy link

@themanjeetkr you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

If you have already signed the agreement, please allow a week for your agreement to be processed.
Once it is processed, you will receive an email invitation to join the plone GitHub organization as a Contributor.

If after a week you have not received an invitation, then please contact agreements@plone.org.

@themanjeetkr
Copy link
Author

Added the missing changelog entry as requested.

Also updated typing for react-aria button props:

  • Added import type { ButtonRenderProps } from 'react-aria-components'
  • Changed (className, renderProps) to (className: string | undefined, renderProps: ButtonRenderProps) to make the types explicit and improve type safety.

@davisagli davisagli requested a review from sneridagh February 12, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants