BSON support provided through bson gem.#163
Merged
nesquena merged 1 commit intonesquena:masterfrom Feb 12, 2012
Antiarchitect:master
Merged
BSON support provided through bson gem.#163nesquena merged 1 commit intonesquena:masterfrom Antiarchitect:master
nesquena merged 1 commit intonesquena:masterfrom
Antiarchitect:master
Conversation
Contributor
|
I've tried add |
|
+1 |
Owner
|
Sweet, great to have BSON support. If we can add something akin to https://github.com/nesquena/rabl/blob/master/test/msgpack_engine_test.rb for BSON, I will merge this and release a new gem version. |
Contributor
Author
|
I think I'll provide some tests soon - lack of time for today. |
Owner
|
Awesome thanks for working on this. |
…active_support/inflector it doesn't work in Rabl::Helpers). Covered by tests, results were compared with msgpack results and matches except for those that returns array - BSON.serialize can't accept arrays so it wraps it into a hash with first object name pluralization as a key.
Contributor
Author
|
I've just corrected my previous commit. Not it is covered by tests, bugs are fixed and it works as needed. |
nesquena
added a commit
that referenced
this pull request
Feb 12, 2012
BSON support provided through bson gem.
Owner
|
OK, added you to the readme, updated the changelog and pushed out 0.5.5.e. Let me know if everything looks OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features: