Centralizing dependencies, bumping dependency versions#1448
Centralizing dependencies, bumping dependency versions#1448jgrnrt wants to merge 16 commits intomockk:masterfrom
Conversation
- java 17 required by junit 6 - kotlin 2.2.20 - coroutines 1.10.2 - logback 1.5.20 - junit jupiter 6.0.1 Signed-off-by: Jeremy Grunert <jgrnrt@gmail.com>
Raibaz
left a comment
There was a problem hiding this comment.
Can you please also add the higher Java and Kotlin versions in the github actions jobs, in .github/workflows/gradle.yml?
- necessary deprecations changes for gradle v9 - add foojay-resolver-convention plugin - add heap config to base convention - bump several dependencies - migrate to develocity plugin - bump min Kotlin version to v2.1 - required by junit 6 - junit 6 api change: fix override in MockKExtensionAfterAllTestTest.kt Signed-off-by: Jeremy Grunert <jgrnrt@gmail.com>
|
I've made some necessary changes to bump to gradle 9. Somehow the tests now need more heap space. I've increased the heap space for tests. |
|
The ProxyWeakReferenceTest is indeed stressing the memory to verify that there are no leaks; it surprises me that upgrading dependencies makes it throw OOME. I suggest adding |
|
I cloned master version of the project in another directory and ran some tests. Output with Gradle 8: Same java.lang.OutOfMemoryError: Java heap space in ProxyWeakReferenceTest.kt:12 with debug logs. Running And running with debug shows the heap error as well: Gradle 9 may have fixed this behavior, so gradle check might now correctly show BUILD FAILED. Additionally, my computer crashed several times before I realized that rerunning those tests were filling up my memory. The ProxyWeakReferenceTest is leaking memory. Or at least the created objects are not being removed from GC, which can be seen in heap dump. I am currently looking into it, but maybe someone with more experience with the project could have a look as well. |
|
Can you please rebase on top of master and retry? I think I found the cause of the memory leak spotted by |
|
...nevermind, that didn't work. I'll keep looking into a fix. |
…ion_with_optional_value_class Fix for issue mockk#1103.
- java 17 required by junit 6 - kotlin 2.2.20 - coroutines 1.10.2 - logback 1.5.20 - junit jupiter 6.0.1 Signed-off-by: Jeremy Grunert <jgrnrt@gmail.com>
- necessary deprecations changes for gradle v9 - add foojay-resolver-convention plugin - add heap config to base convention - bump several dependencies - migrate to develocity plugin - bump min Kotlin version to v2.1 - required by junit 6 - junit 6 api change: fix override in MockKExtensionAfterAllTestTest.kt Signed-off-by: Jeremy Grunert <jgrnrt@gmail.com>
reverting jvmargs, bump gradle 9.2.1 Signed-off-by: Jeremy Grunert <jgrnrt@gmail.com>
dokka bump to 2.1.0, make necessary migrations for dokka 2.1.0, centralizing dependencies in libs.versions.toml, remove redundant versioning, remove duplicate androidxOrchestrator dependency, fix several deprecation notices, bump kotlinx-benchmark 0.4.14 Signed-off-by: Jeremy Grunert <jgrnrt@gmail.com>
# Conflicts: # buildSrc/build.gradle.kts # buildSrc/src/main/kotlin/buildsrc/config/Deps.kt # buildSrc/src/main/kotlin/buildsrc/convention/base.gradle.kts # buildSrc/src/main/kotlin/buildsrc/convention/kotlin-jvm.gradle.kts # buildSrc/src/main/kotlin/buildsrc/convention/kotlin-multiplatform.gradle.kts # gradle/wrapper/gradle-wrapper.properties
Signed-off-by: Jeremy Grunert <jgrnrt@gmail.com>
Test problemsProxyWeakReferenceTest prevents subsequent tests from running across all branches. Disabling this problematic test allows the remaining tests to execute properly. ChangesCentralized all dependencies into libs.versions.toml for easier dependency management JUnit 6How should we proceed with the JUnit 6 dependency? Options:
I'm not certain postponing the JUnit 6 migration is the best approach. What are your thoughts? |
Given that JUnit 6 was released less than two months ago and the vast majority of the existing codebases still rely on JUnit 5, I think we should hold off on breaking compatibility with JDK <17 and Kotlin <2 for now. |
- migration to dokka v2 (currently investigating issues) - add repositoriesMode into repositories.settings.gradle.kts - jvmTests currently running endlessly (investigating) - downgrade to junit 5 - revert kotlin versions in matrix - bump gradle action version Signed-off-by: Jeremy Grunert <jgrnrt@gmail.com>
- fix incorrect usage of @sample in KDoc - migration to dokka v2 (currently investigating issues) - add repositoriesMode into repositories.settings.gradle.kts - jvmTests currently running endlessly (investigating) - downgrade to junit 5 - revert kotlin versions in matrix - bump gradle action version - remove idea plugin to enable configuration-cache Signed-off-by: Jeremy Grunert <jgrnrt@gmail.com>
- Fix incorrect links in KDoc - Add Kotlin plugin in android-application.gradle.kts to support Dokka generation - Add docs project for generating full API documentation for upcoming documentation website overhaul - Add JUnit BOM to prevent missing junit-platform-launcher - Disable "given car when test without require parallel testing execution returns successfully" test that runs endlessly Signed-off-by: Jeremy Grunert <jgrnrt@gmail.com>
|
Only one additional test was running endlessly. I've disabled it. Project builds very quick now with activated configuration cache. Dokka generation for the whole project works as well. Split package links can't be resolved with Dokka. Which hopefully will be fixed in the future. See Kotlin/dokka#4364 |
- incorporate mockk#1455 - add additional api levels in pipeline - bump sdk to 36 - bump dependencies Signed-off-by: Jeremy Grunert <jgrnrt@gmail.com>
|
I am not sure on how to fix the illegal class access error: |
changes:
...