Handle multiple path variables at the same path level#38
Merged
matthewmcgarvey merged 1 commit intoluckyframework:masterfrom Oct 27, 2020
matthewmcgarvey:multiple-path-variables
Merged
Handle multiple path variables at the same path level#38matthewmcgarvey merged 1 commit intoluckyframework:masterfrom matthewmcgarvey:multiple-path-variables
matthewmcgarvey merged 1 commit intoluckyframework:masterfrom
matthewmcgarvey:multiple-path-variables
Conversation
Member
|
Just so I'm clear here... |
Member
Author
|
@jwoertink exactly |
Member
|
Nice!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1 (It called for raising an error, but it is easy enough to just handle it as expected)
Summary
This adds support for multiple path variables for a single section of a path. So, the router will now handle
/users/:idand/users/:user_id/settingsas expected. Before, it would only keep the first one that was added to the router and all others would be dropped. Now we store them all in an internal list.Benchmark (with
--release)