Merged
Conversation
jwoertink
reviewed
Nov 19, 2020
| URI.parse(url).path | ||
| end | ||
|
|
||
| def accept_alert |
Member
There was a problem hiding this comment.
What's the difference between these two methods? Since this isn't a confirm() modal, what are you "accept"ing?
Member
Author
There was a problem hiding this comment.
I think since it's an alert they do the same thing. If it was a confirm then it would do different things
jwoertink
approved these changes
Nov 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67
One thing I was surprised by is that you cannot take screenshots if an alert is present. Some selenium libraries might implement functionality around taking a screenshot of the "browser" instead of just the element/window to get around this.
https://stackoverflow.com/questions/47693245/how-can-i-take-a-screenshot-of-an-alert-using-selenium-webdriver-in-ruby
https://stackoverflow.com/questions/21670361/capture-screenshot-of-alert