Change default generated app to build a generic target#742
Merged
jwoertink merged 1 commit intoluckyframework:mainfrom Mar 27, 2022
Merged
Change default generated app to build a generic target#742jwoertink merged 1 commit intoluckyframework:mainfrom
jwoertink merged 1 commit intoluckyframework:mainfrom
Conversation
jwoertink
reviewed
Mar 19, 2022
Member
jwoertink
left a comment
There was a problem hiding this comment.
I think there's a few other places this has to be changed. Like
for exampleAlso, I forget, but maybe the Heroku buildpack may also need to be updated? I'll try to dig around the ecosystem a bit and see where all this gets used. Thanks for getting this started!
Contributor
Author
|
I'll |
Contributor
Author
|
Ooh nice, one .ecr taken away, certainly a win in my eyes |
This allows for easier devops/DX by being able to have a reliable bin/app generated on build Which greatly cleans up universal Dockerfiles Resolves luckyframework#735
Contributor
Author
|
Oop, forgot to mark this as ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for easier devops/DX by being able to have a reliable bin/app generated on build
Which greatly cleans up universal Dockerfiles
Resolves #735