Skip to content

Fix append class with no default#842

Merged
paulcsmith merged 1 commit intomasterfrom
pcs/fix-append-replace-class
Jul 5, 2019
Merged

Fix append class with no default#842
paulcsmith merged 1 commit intomasterfrom
pcs/fix-append-replace-class

Conversation

@paulcsmith
Copy link
Member

@paulcsmith paulcsmith commented Jul 5, 2019 •
edited
Loading

Closes #841

This fixes an issue where 'append_class' did not work if there was no default class

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@paulcsmith paulcsmith mentioned this pull request Jul 5, 2019
Closed
@paulcsmith paulcsmith force-pushed the pcs/fix-append-replace-class branch from d04567c to 7e1a10c Compare July 5, 2019 20:08
@paulcsmith paulcsmith force-pushed the pcs/fix-append-replace-class branch from 7e1a10c to 6bc442f Compare July 5, 2019 20:09
@paulcsmith paulcsmith merged commit 5349713 into master Jul 5, 2019
@paulcsmith paulcsmith changed the title Fix append/replace_class with no default Fix append class with no default Jul 5, 2019
@paulcsmith paulcsmith mentioned this pull request Jul 5, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix append/replace_class with no default class

1 participant

@paulcsmith