Fix BaseHTTPClient params#726
Merged
paulcsmith merged 1 commit intoluckyframework:masterfrom Mar 9, 2019
Merged
Conversation
The underlying `HTTP::Client` was expecting a host, but we were providing it a base URI (which is the combined host and port). It was also deriving its default value from the `RouteHelper`, but the requests are expected to be made to the `Server` *first*. This also enables the host to be configured without overriding the client.
paulcsmith
approved these changes
Mar 9, 2019
Member
paulcsmith
left a comment
There was a problem hiding this comment.
This makes sense. Thanks for nice explanation and the fix :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying
HTTP::Clientwas expecting a host, but we wereproviding it a base URI (which is the combined host and port).
It was also deriving its default value from the
RouteHelper, but therequests are expected to be made to the
Serverfirst.This also enables the host to be configured without overriding the
client.