Conversation
jwoertink
commented
Mar 31, 2024
Comment on lines
+52
to
+58
| # Doing this because `component_class` will raise an exception if the value is missing | ||
| # but the error message would say "component_class is missing" which isn't as nice of | ||
| # an error message. This lets the UI remain the same until this whole deal can be refactored | ||
| component_class | ||
| nil | ||
| rescue | ||
| "Component name is required." |
Member
Author
There was a problem hiding this comment.
This is mainly just to keep the output the same as it is now. I have an issue on LuckyTask luckyframework/lucky_task#8 so we can address this later.
mdwagner
approved these changes
Apr 1, 2024
Contributor
mdwagner
left a comment
There was a problem hiding this comment.
Looks good! I totally forgot about this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1832
Ref #1746
Description
We originally used Teeplate for all of the tasks that generate files. It was a good template system, but it doesn't really work on Windows. We now have LuckyTemplate which does work on Windows. By migrating this system over, this will bring Lucky to Windows compatibility 1 more step closer.
Checklist
crystal tool format spec src./script/setup./script/test