Conversation
… an exception. We catch that and return nil so Habitat will throw the missing setting error. Fixes #46
jwoertink
commented
Jun 23, 2020
paulcsmith
approved these changes
Jun 25, 2020
Member
paulcsmith
left a comment
There was a problem hiding this comment.
I can't think of a good way to test this. Maybe add a comment above line 195 that explain it must use the begin so it properly raises errors? Up to you though!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46
If you set a setting default value to some method you may have written, and that method could raise an exception at some point, then you'll get a weird unexpected error about some recursion stuff. With this PR, we just rescue any possible exceptions, and return
nil. This will cause Habitat to raise aMissingSettingErrorwhich tells you which setting failed.