Conversation
jwoertink
commented
Sep 12, 2023
|
|
||
| def initialize(@table : TableName, @columns : Columns, @using : Symbol = :btree, @unique = false, @name : String? | Symbol? = nil) | ||
| raise "index type '#{using}' not supported" unless ALLOWED_INDEX_TYPES.includes?(using.to_s) | ||
| def initialize(@table : TableName, @columns : Columns, using : Symbol = :btree, @unique = false, @name : String? | Symbol? = nil) |
Member
Author
There was a problem hiding this comment.
I was going to make this use the enum instead of a Symbol, but due to how the Crystal autocast works with passing a Symbol, it would have been a breaking change. This can be an optimization for later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #969
While I was in there already, I just decided to add a few other supported index types. The only one I didn't add was the
sp-gistwhich seems to be likegistbut slightly more limited? I guess if anyone really wants it, we can add it in, but just made the code more complex since I couldn't justSpGist.to_s.downcase😬