Allow nil on size and inclusion validations.#299
Merged
paulcsmith merged 7 commits intoluckyframework:masterfrom Feb 9, 2020
wout:validations-with-allow-nil
Merged
Allow nil on size and inclusion validations.#299paulcsmith merged 7 commits intoluckyframework:masterfrom wout:validations-with-allow-nil
paulcsmith merged 7 commits intoluckyframework:masterfrom
wout:validations-with-allow-nil
Conversation
paulcsmith
reviewed
Feb 9, 2020
Member
paulcsmith
left a comment
There was a problem hiding this comment.
A couple small comments. Thanks for doing this!
Co-Authored-By: Paul Smith <paulcsmith@users.noreply.github.com>
Co-Authored-By: Paul Smith <paulcsmith@users.noreply.github.com>
Contributor
Author
|
In this proposal, the original method keeps its original shape (more or less) and an overload is created specifically for the |
paulcsmith
reviewed
Feb 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #293, this PR adds an
allow_niloption forvalidate_size_ofandvalidate_inclusion_of.