Fix missing nested param error for nested array params#1085
Merged
jwoertink merged 3 commits intoluckyframework:mainfrom Apr 28, 2025
akadusei:nested-param-error
Merged
Fix missing nested param error for nested array params#1085jwoertink merged 3 commits intoluckyframework:mainfrom akadusei:nested-param-error
jwoertink merged 3 commits intoluckyframework:mainfrom
akadusei:nested-param-error
Conversation
`Lucky::Params#nested_arrays?` returns a hash, which is truthy.
`Lucky::Params#nested_file?` returns a hash always, although its signature says it returns a nilable hash.
Even if nested params is not empty, Lucky would still raise
`Lucky::MissingNestedParamError` if any array attributes are empty.
You had to fill in the array attribute to avoid the error:
```
response = client.exec(Features::Create, feature: {
choices: Array(String).new, # Without this, you get "Missing param key: 'feature' (Lucky::MissingNestedParamError)..."
maximum: 99,
minimum: 3,
name: "Number of Kitchens",
type: :integer
})
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even if nested params is not empty, Lucky would still raise
Lucky::MissingNestedParamErrorif any array attributes are not set.You had to fill in the array attribute to avoid the error:
See luckyframework/lucky#1949