manage raw where clause with array as param#1044
Merged
jwoertink merged 2 commits intoluckyframework:mainfrom Jun 16, 2024
Merged
manage raw where clause with array as param#1044jwoertink merged 2 commits intoluckyframework:mainfrom
jwoertink merged 2 commits intoluckyframework:mainfrom
Conversation
jwoertink
approved these changes
May 22, 2024
Member
jwoertink
left a comment
There was a problem hiding this comment.
oh awesome! You know, I'm not sure why the ? was used instead of bind variables... My only guess is because that's what Rails did? 🤷♂️ I know it has made a few of the jsonb operations a bit difficult.
I guess thinking about it.... If you did UserQuery.new.admin(true).where("something = ?", whatever) you'd have to know that the admin(true) is already using $1, so your ? would need to be $2 in this case. That could get real messy trying to track that in larger queries where you might use methods for a larger portion like
UserQuery.new.for_some_special_case.where("something = $5", whatever)
😂 I don't know if that's the real reason or not, but that's my best guess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1031
Btw, is there any reason for which the raw does param substitution and does not use bind variables? Albeit small, there might be a perf hit, in that case