Skip to content

QA Improvements + 100% Type Coverage for v4#56

Merged
Ocramius merged 5 commits intolaminas:4.0.xfrom
gsteel:v4/misc-qa
Jul 17, 2024
Merged

QA Improvements + 100% Type Coverage for v4#56
Ocramius merged 5 commits intolaminas:4.0.xfrom
gsteel:v4/misc-qa

Conversation

@gsteel
Copy link
Member

@gsteel gsteel commented Jul 17, 2024

Q A
Documentation yes
QA yes

Description

Minor QA stuff - the baseline is now down to 3 issues with 100% type coverage 🎉

gsteel added 4 commits July 17, 2024 09:38
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
@Ocramius
Copy link
Member

Psalm was able to infer types for 100% of the codebase

Impressive, for a library that does inference on callables :O

@Ocramius Ocramius self-assigned this Jul 17, 2024
@Ocramius Ocramius merged commit c8fea4e into laminas:4.0.x Jul 17, 2024
@Ocramius
Copy link
Member

Thanks @gsteel!

@gsteel gsteel deleted the v4/misc-qa branch July 17, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants