This repository was archived by the owner on Aug 19, 2024. It is now read-only.
BLS PopProve and PopVerify use different DomainSeparationTag#2052
Merged
blukat29 merged 1 commit intoklaytn:devfrom Nov 27, 2023
Merged
BLS PopProve and PopVerify use different DomainSeparationTag#2052blukat29 merged 1 commit intoklaytn:devfrom
blukat29 merged 1 commit intoklaytn:devfrom
Conversation
ian0371
approved these changes
Nov 27, 2023
Contributor
ian0371
left a comment
There was a problem hiding this comment.
Checked the issue is resolved
hyeonLewis
approved these changes
Nov 27, 2023
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
bls.PopProveandbls.PopVerifyto use the standard domain separation tag for proof-of-poessession purpose.which is the underlying library of python
blspyand node.jsbls-signatures.Types of changes
Checklist
$ make test)Related issues
Problem spotted by @ian0371 at #2043 (comment).
Further comments