This repository was archived by the owner on Aug 19, 2024. It is now read-only.
Call tracing result compatibility with Ethereum#1953
Merged
sjnam merged 6 commits intoklaytn:devfrom Sep 13, 2023
sjnam:debug-trace
Merged
Call tracing result compatibility with Ethereum#1953sjnam merged 6 commits intoklaytn:devfrom sjnam:debug-trace
sjnam merged 6 commits intoklaytn:devfrom
sjnam:debug-trace
Conversation
Contributor
|
The existing implementation did not consider the 'initial gas' for the usage in the following context. The passed argument to the context of EVM is the residual gas that subtracts the intrinsic gas. You may refer the geth patch for this problem. |
blukat29
previously approved these changes
Sep 7, 2023
hyunsooda
previously approved these changes
Sep 7, 2023
blockchain/vm/evm.go
Outdated
| // virtual machine configuration options used to initialise the | ||
| // evm. | ||
| vmConfig *Config | ||
| VmConfig *Config |
Contributor
There was a problem hiding this comment.
How about the name VMConfig instead?
yoomee1313
previously approved these changes
Sep 7, 2023
Contributor
There was a problem hiding this comment.
@sjnam Shouldn't the description be updated? Previously, gasUsed field was not matched with receipt when it's CA, but with PR, it became matched. Isn't it?
4340f39
yoomee1313
approved these changes
Sep 8, 2023
blukat29
approved these changes
Sep 8, 2023
hyunsooda
approved these changes
Sep 10, 2023
This was referenced Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR
gasUsedfield of the test result.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...