Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Changed TryCatchUpWithPrimary method periodically#1947

Merged
blukat29 merged 2 commits intoklaytn:devfrom
jeongkyun-oh:230816-unlimited-max-open-files
Aug 29, 2023
Merged

Changed TryCatchUpWithPrimary method periodically#1947
blukat29 merged 2 commits intoklaytn:devfrom
jeongkyun-oh:230816-unlimited-max-open-files

Conversation

@jeongkyun-oh
Copy link
Contributor

@jeongkyun-oh jeongkyun-oh commented Aug 23, 2023

Proposed changes

  • TryCatchUpWithPrimary consumes too much resource whenever it is called on Get/Has method. So, this catchup method is moved to current block update method.
  • Secondary instance must use unlimited max open files so that it is forced to set the configuration whenever it should be.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@blukat29 blukat29 merged commit bac5345 into klaytn:dev Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants