Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

tx_list: bump tx max size to 128KB#1733

Merged
yoomee1313 merged 5 commits intoklaytn:devfrom
yoomee1313:bump-max-tx-size
Jan 18, 2023
Merged

tx_list: bump tx max size to 128KB#1733
yoomee1313 merged 5 commits intoklaytn:devfrom
yoomee1313:bump-max-tx-size

Conversation

@yoomee1313
Copy link
Contributor

@yoomee1313 yoomee1313 commented Dec 2, 2022

Proposed changes

  • it increases tx max size to 128KB
  • slot is introduced. For example, if a slot size is 32KB, and the tx size is 96kB, when that tx is inserted into txpool, it adds 96+32-1/32 = 3 slots.
    • dev: 1 is added to the txpool tx count when a tx is inserted
    • PR: tx slot size is added to the txpool tx count(which is actually slots) when a tx is inserted. See numSlots.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@baerae-colin
Copy link

@yoomee1313 Change is too big to be included after the code freeze. Let's talk about this in our internal meeting.

@yoomee1313
Copy link
Contributor Author

This PR will be included in v1.10.1 or v1.11.0.

@yoomee1313
Copy link
Contributor Author

yoomee1313 commented Dec 29, 2022

This PR is too complicated.. I have seperated some changes into next PR #1748. Please review it first.
-> #1748 is merged.

@yoomee1313 yoomee1313 marked this pull request as ready for review December 30, 2022 06:34
blukat29
blukat29 previously approved these changes Jan 11, 2023
ian0371
ian0371 previously approved these changes Jan 11, 2023
@yoomee1313 yoomee1313 requested a review from hyunsooda January 12, 2023 05:42
hyunsooda
hyunsooda previously approved these changes Jan 12, 2023
kjeom
kjeom previously approved these changes Jan 13, 2023
@yoomee1313 yoomee1313 merged commit 50c5b47 into klaytn:dev Jan 18, 2023
@yoomee1313 yoomee1313 deleted the bump-max-tx-size branch January 18, 2023 01:33
@blukat29 blukat29 added this to the v1.10.2 milestone Feb 22, 2023
@aidan-kwon aidan-kwon mentioned this pull request Feb 23, 2023
@blukat29 blukat29 mentioned this pull request Mar 3, 2023
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants