This repository was archived by the owner on Aug 19, 2024. It is now read-only.
Safely handle corner cases in Tracers#1576
Merged
aidan-kwon merged 9 commits intoklaytn:devfrom Aug 16, 2022
Merged
Conversation
79b4537 to
709faa0
Compare
jeongkyun-oh
approved these changes
Aug 11, 2022
ian0371
approved these changes
Aug 16, 2022
9 tasks
aidan-kwon
approved these changes
Aug 16, 2022
aidan-kwon
pushed a commit
to aidan-kwon/klaytn
that referenced
this pull request
Aug 18, 2022
Safely handle corner cases in Tracers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
internaltx_tracer.go)abi.UnpackRevert()to parse revert output.call_tracer.js)bigInt()revert_tracer.js)bigInt()Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments