Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Safely handle corner cases in Tracers#1576

Merged
aidan-kwon merged 9 commits intoklaytn:devfrom
blukat29:calltracer-corner-case
Aug 16, 2022
Merged

Safely handle corner cases in Tracers#1576
aidan-kwon merged 9 commits intoklaytn:devfrom
blukat29:calltracer-corner-case

Conversation

@blukat29
Copy link
Contributor

@blukat29 blukat29 commented Aug 3, 2022

Proposed changes

  • Harden fastCallTracer (internaltx_tracer.go)
    • Use abi.UnpackRevert() to parse revert output.
  • Harden callTracer (call_tracer.js)
    • Try-catch bigInt()
  • Harden revertTracer (revert_tracer.js)
    • Try-catch bigInt()
  • Update tracers test code
    • Respect the chainConfig in the testdata json
    • New helper scripts to generate testdata json
  • Add testdata related to this fix and previous fixes (#1527, #1549)

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

@blukat29 blukat29 force-pushed the calltracer-corner-case branch from 79b4537 to 709faa0 Compare August 3, 2022 11:18
@blukat29 blukat29 self-assigned this Aug 3, 2022
@blukat29 blukat29 added this to the v1.9.1 milestone Aug 3, 2022
@blukat29 blukat29 marked this pull request as ready for review August 4, 2022 00:37
@aidan-kwon aidan-kwon added the need to merge Need to merge for the next time label Aug 16, 2022
Copy link
Contributor

@hyunsooda hyunsooda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aidan-kwon aidan-kwon merged commit 3ec6fd3 into klaytn:dev Aug 16, 2022
aidan-kwon pushed a commit to aidan-kwon/klaytn that referenced this pull request Aug 18, 2022
@blukat29 blukat29 removed the need to merge Need to merge for the next time label Feb 17, 2023
@blukat29 blukat29 deleted the calltracer-corner-case branch April 21, 2023 04:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants