Skip to content

Update to Docker v29.1.2, runC v1.3.4, containerd v2.2.0#4429

Merged
sairon merged 1 commit intodevfrom
docker-29.1.2
Dec 4, 2025
Merged

Update to Docker v29.1.2, runC v1.3.4, containerd v2.2.0#4429
sairon merged 1 commit intodevfrom
docker-29.1.2

Conversation

@sairon
Copy link
Member

@sairon sairon commented Dec 3, 2025 •
edited by coderabbitai bot
Loading

Update to the latest versions and update tests to use the new schema of the inspect output.

  • buildroot 0aa9729cd5...808ee7b916 (4):

    package/docker-engine: bump version to v29.1.2
    package/docker-cli: bump version to v29.1.2
    package/containerd: bump version to v2.2.0
    package/runc: bump version to v1.3.4

Summary by CodeRabbit

  • Chores
    • Updated infrastructure dependencies for system compatibility.
    • Enhanced testing procedures to improve reliability of container network detection during supervisor initialization and restart operations.

✏️ Tip: You can customize this high-level summary in your review settings.

@sairon
Update to Docker v29.1.2, runC v1.3.4, containerd v2.2.0
25898ee 
Update to the latest versions and update tests to use the new schema of the
inspect output.

* buildroot 0aa9729cd5...808ee7b916 (4):
  > package/docker-engine: bump version to v29.1.2
  > package/docker-cli: bump version to v29.1.2
  > package/containerd: bump version to v2.2.0
  > package/runc: bump version to v1.3.4
@sairon sairon added the os label Dec 3, 2025
@sairon
Copy link
Member Author

sairon commented Dec 3, 2025

Buildroot PR:

Note there is no docker:29.1.2-dind on Docker Hub at the time of writing yet, so the build fails without adjustments in the hassio package. Tested locally with docker:29.1.1-dind but we should wait with the merge/build until 29.1.2 appears here: https://hub.docker.com/_/docker

@sairon sairon requested a review from agners December 3, 2025 15:38
agners
agners reviewed Dec 3, 2025
View reviewed changes
Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No rebasing needed of the containerd/runc patches needed? 🤔

@sairon
Copy link
Member Author

sairon commented Dec 4, 2025

@agners No, the runC release changeset is small, the patches apply without any offsets. Containerd doesn't need any patching.

Undrafting the PR, correct DinD version is in the registry now.

@sairon sairon marked this pull request as ready for review December 4, 2025 07:16
@sairon sairon requested a review from agners December 4, 2025 07:16
@coderabbitai
Copy link

coderabbitai bot commented Dec 4, 2025

📝 Walkthrough

Walkthrough

A buildroot subproject reference was updated to a new commit hash. Additionally, two Docker inspection commands in a supervisor test were modified to retrieve container IP addresses from the bridge network path instead of the legacy path, with no changes to control flow or logic.

Changes

Cohort / File(s) Summary
Subproject reference update
buildroot		 Commit reference updated; no code or behavioral changes
Docker IP retrieval updates
tests/supervisor_test/test_supervisor.py		 Two Docker inspection commands modified to retrieve container IP from .NetworkSettings.Networks.bridge.IPAddress instead of .NetworkSettings.IPAddress; affects supervisor container IP retrieval during startup and restart operations

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify the new bridge network IP retrieval path is compatible with the Docker API version in use
  • Confirm both command updates are semantically equivalent and produce the expected results in test execution

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating three container tools to specific versions (Docker v29.1.2, runC v1.3.4, containerd v2.2.0), which aligns with the subproject commits and PR objectives.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch docker-29.1.2
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 0354f47 and 25898ee.

📒 Files selected for processing (2)
  • buildroot (1 hunks)
  • tests/supervisor_test/test_supervisor.py (2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
tests/supervisor_test/test_supervisor.py (2)
tests/conftest.py (1)
  • shell (46-50)
tests/qemu_shell_strategy.py (1)
  • run_check (26-27)
🔇 Additional comments (2)
buildroot (1)

1-1: Remove this review comment - it is not a legitimate code review.

This comment is structured as a verification request template with shell script examples rather than actionable feedback on the PR. The buildroot subproject reference update to commit 808ee7b91641925b4b7bb4bd400494e172265daf is already applied, the Docker version updates (v29.1.2, containerd v2.2.0, runc v1.3.4) are correctly documented in the repository history, and tests already use the correct Docker inspect output path (.NetworkSettings.Networks.bridge.IPAddress). This appears to be leftover from an abandoned verification process and should be resolved.

Likely an incorrect or invalid review comment.

tests/supervisor_test/test_supervisor.py (1)

32-32: Correctly adapts to Docker v29.1.2 inspect schema changes.

The update from .NetworkSettings.IPAddress to .NetworkSettings.Networks.bridge.IPAddress aligns with Docker Engine v29's breaking changes, where legacy top-level NetworkSettings fields were deprecated and network-specific data moved to NetworkSettings.Networks. This is the correct approach for retrieving container IP addresses in Docker v29.1.2. No other files in the codebase use the legacy pattern.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sairon sairon merged commit 9e5a74f into dev Dec 4, 2025
3 checks passed
@sairon sairon deleted the docker-29.1.2 branch December 4, 2025 14:55
@sairon sairon mentioned this pull request Dec 8, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@agners agners agners approved these changes

Assignees

No one assigned

Labels

cla-signed os

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sairon @agners