Skip to content

docs: fix spelling#565

Merged
dandhlee merged 5 commits intogoogleapis:masterfrom
slowy07:get-fixing
Jul 25, 2021
Merged

docs: fix spelling#565
dandhlee merged 5 commits intogoogleapis:masterfrom
slowy07:get-fixing

Conversation

@slowy07
Copy link
Contributor

@slowy07 slowy07 commented Jul 22, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #564 🦕

@slowy07 slowy07 requested review from a team as code owners July 22, 2021 07:21
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Jul 22, 2021
parthea
parthea reviewed Jul 22, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @slowy07! Please note: Some of these files are templated or auto-generated so the changes may be reverted until the source is fixed.

parthea
parthea reviewed Jul 22, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments where I have submitted fixes internally for the source.

@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 22, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 22, 2021
@slowy07 slowy07 requested review from dandhlee and parthea and removed request for a team July 23, 2021 01:09
@dandhlee dandhlee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 23, 2021
dandhlee
dandhlee requested changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bit more :)

@slowy07 slowy07 requested a review from dandhlee July 23, 2021 04:55
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 23, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 23, 2021
parthea
parthea approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea
Copy link
Contributor

parthea commented Jul 23, 2021

Thanks @slowy07!

@slowy07
Copy link
Contributor Author

slowy07 commented Jul 23, 2021

Thanks @slowy07!

thanks for everything @parthea !

dandhlee
dandhlee approved these changes Jul 25, 2021
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Changing the title from fix: to docs: to avoid confusion on the release note.

@dandhlee dandhlee changed the title fix: miss spelling docs: miss spelling Jul 25, 2021
@dandhlee dandhlee changed the title docs: miss spelling docs: fix spelling Jul 25, 2021
@dandhlee dandhlee merged commit fe5c702 into googleapis:master Jul 25, 2021
@slowy07 slowy07 deleted the get-fixing branch July 25, 2021 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

@dandhlee dandhlee dandhlee approved these changes

Assignees

@dandhlee dandhlee

Labels

api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix miss spelling

4 participants

@slowy07 @parthea @dandhlee @yoshi-kokoro