feat: add cancel method to pipeline client#488
Merged
ji-yaqi merged 6 commits intogoogleapis:masterfrom Jun 21, 2021
Merged
Conversation
sasha-gitg
approved these changes
Jun 21, 2021
| def _has_run(self) -> bool: | ||
| """Helper property to check if this pipeline job has been run.""" | ||
| return bool(self._gca_resource.name) | ||
| return bool(self._gca_resource.create_time) |
Member
There was a problem hiding this comment.
What is the motivation for relying on create_time? I wonder if we should use it elsewhere.
Contributor
Author
There was a problem hiding this comment.
For Pipeline Job, name is created by us from the SDK side, so it will exist even if we don't start the run. (Compared to other jobs, their names are created from the BE)
Contributor
Author
|
The Kokoro doc presubmit error is tracked in: googleapis/sphinx-docfx-yaml#47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.