✅ Deploy Preview for fakerjs ready!

Name	Link
🔨 Latest commit	22084c5
🔍 Latest deploy log	https://app.netlify.com/projects/fakerjs/deploys/69b8047a7209530008bf3303
😎 Deploy Preview	https://deploy-preview-3558.fakerjs.dev
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.88%. Comparing base (67defc8) to head (22084c5).

@@           Coverage Diff           @@
##             next    #3558   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files         886      886           
  Lines        3062     3062           
  Branches      540      556   +16     
=======================================
  Hits         3028     3028           
  Misses         30       30           
  Partials        4        4           

I'll need to verify that this build works as expected using the playground. Might take some time, as it doesn't have any priority for me right now.

I'll need to verify that this build works as expected using the playground. Might take some time, as it doesn't have any priority for me right now.

Sure, take your time. This is not a breaking change and can theoretically merged any time.

I use it already in unuse and here I checked it in the preview docs console.

It took some time - sorry about that.

Multiple things:

• the PR needs a rebase or merge of the next branch
• while testing I saw that tsdown has new versions, maybe we want to directly migrate to those
• tsdown hashes all files, including the "dist/index.js" and the "dist/index.d.ts" file. Because of that, the exports defined in the package.json do not work (ERROR pkg.exports["."].types is ./dist/index.d.ts but the file does not exist.) - this needs to be addressed

@Shinigami92 are you up to the task?

Yes, can look into that.
However right now I can't reach my PC, and my laptop reached 0% battery 🫣 and the power cable isn't strong enough 🥲

@xDivisionByZerox updated everything

tsdown hashes all files, including the "dist/index.js" and the "dist/index.d.ts" file. Because of that, the exports defined in the package.json do not work (ERROR pkg.exports["."].types is ./dist/index.d.ts but the file does not exist.) - this needs to be addressed

I'm not sure if you e.g. forget to clean something or not, however, tsdown is checking the exports field with publint and on my machine everything looks fine 🤔

I'm not sure if you e.g. forget to clean something or not, however, tsdown is checking the exports field with publint and on my machine everything looks fine 🤔

You are right. I honestly can't tell you what the problem was (invalid dependency cache, legacy artifacts or whatever) - i can now get the project to build on my machine as well.

I'm running into the next problem, tho. I cannot get the CJS (Jest) playground to run probably with a locally linked dependency. You might want to give it a try, because I'm currently at my limit with this jest configuration nonsense...

I played a bit with the bundler options for #3748 . And it looks like adding @PURE to simpleFaker helps reducing the final bundle size by 5 kB gzipped (since it no longer shows up uselessly). However, tsup removes the annotations during the minification step. tsdown has options to keep it.
I haven't tested tsdown yet, but that might actually help with cutting down final bundle sizes (both for faker as a lib and the user's final bundle).

https://rolldown.rs/reference/OutputOptions.comments

Also if I interpret the OP correctly, then tsdown produces smaller bundle sizes either way, so I will refrain from analysing too deeply why a particular import ended up in the final bundle or not.

We probably should add a tsdown project to our playground to help comparing final vite/tsup/tsdown builds with each other. We might be able to put them all in one project and just call them with different aliases e.g. build:tsdown ...
This should help with finding which exports/consts we need to annotate or not.
Maybe we can even reduce the bundle size for everyone by marking Faker module fields/methods with pure, so they may get stripped if unused.

@Shinigami92 Can you estimate, when you have time to tackle the remaining tests?

@Shinigami92 Can you estimate, when you have time to tackle the remaining tests?

It's a bit hard for me to make promises, because I just landed in my new job, am a bit ill the last 4 days, managing hobbies like gaming and series.
I didn't have much time left this week and today I'm also away outside with friends...
So sorry that I couldn't fulfill my promise that I come to this this week.
Hopefully next week, I might need to claim dedicated time for this task.

I'm running into the next problem, tho. I cannot get the CJS (Jest) playground to run probably with a locally linked dependency. You might want to give it a try, because I'm currently at my limit with this jest configuration nonsense...

Hey @xDivisionByZerox & @ST-DDT, I updated this PR and tried it locally with faker-playground.
It does not work out of the box, but the terminal is telling me that I need to set "allowJs": true in https://github.com/faker-js/playground/blob/main/playgrounds/jest-cjs/tsconfig.json, and when I do so, everything runs green (when switching overrides-for-dev to overrides against this locally build PR).

Does it need the allowJs always or just with the tsdown build?

Does it need the allowJs always or just with the tsdown build?

I just wanted to respond with obviously tsdown only..., but then checked out everything manually and you are right 😲 our jest-cjs playground is just "broken"/miss-configured and fixed by adding this "allowJs": true

without it, it fails in both cases, with it it works green with both cases