[Contrib/ingame_reports] Proposal: Add i18n support (wrap user-facing strings in _()) #3813
-
|
Hi everyone! Does this sound like a useful contribution for Evennia? Thanks a lot for your guidance! Edit: Title adjusted because I accidentally mentioned the wrong contrib. |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 3 replies
-
|
I think in general localization contributions are appreciated, but I don't think there are any user-facing messages in the Traits contrib, specifically? They're all either data-defined within the game, or they're developer-side. |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for your reply. I don't know how this could have happened (it was probably a bit late when I started the discussion), but I actually didn't mean the I assume that what is described at https://www.evennia.com/docs/latest/Coding/Version-Control.html#fixing-an-evennia-bug-or-feature applies to this type of contribution? |
Beta Was this translation helpful? Give feedback.
-
|
Here are the code style guidelines: https://www.evennia.com/docs/latest/Coding/Evennia-Code-Style.html Beyond that, @Griatch is the only member that can accept a PR so if he has any critiques I'm sure he'll leave feedback in review. +1 to localization contributions being appreciated. |
Beta Was this translation helpful? Give feedback.
-
|
The internationalization documentation is actually here (you find it by searching docs for i18n for example...): https://www.evennia.com/docs/latest/Concepts/Internationalization.html Overall, we don't translate commands and things that are directly meant to be customized by the user anyway. i18n are for hard coded in-engine strings that are not easy to change on your own. I'm honestly not sure about contribs; they are optional code that are not part of core, some of them are also semi-maintained by their original creators. And moreover, if we start translating contribs, it will fill out the translation files with optional strings not part of core. I would say that if the in-game reports contains hard-coded strings not meant to be changed, those could be translated. But most such strings are usually in commands, which should not be. |
Beta Was this translation helpful? Give feedback.
-
|
Okay, I understand. In However, there are some texts in return "There is nothing there for you to manage.", {}contrib/base_systems/ingame_reports/menu.py#L50 that could perhaps be translated, since they don't change? |
Beta Was this translation helpful? Give feedback.
-
|
Yes, that would be an example of a hardcoded string. |
Beta Was this translation helpful? Give feedback.
Yes, that would be an example of a hardcoded string.