Conversation
References #3453
require lib-gtk 3.20 for running
WalkthroughUpdates CI workflows and configuration to JavaFX/OpenJFX 25 across Linux, macOS (x64 and arm64), and Windows (x64). Replaces OpenJFX JMOD download URLs and SHA256 hashes. Removes the -Djavafx.platform property from Maven invocations. Removes the --sun-misc-unsafe-memory-access=allow option from jpackage steps. Drops Windows ARM64 matrix entries and related artifacts in win-exe.yml. Bumps javafx.version in pom.xml to 25 and updates IntelliJ project JDK to 25 in .idea/misc.xml. Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/win-exe.yml (1)
108-112: Bug: jlink help check uses command substitution; condition never executes as intendedThe current
if ! $(${JAVA_HOME}/bin/jlink --help | grep -q "...")attempts to execute an empty string. Use negation over the pipeline (as in mac workflow).Apply this diff:
- if ! $(${JAVA_HOME}/bin/jlink --help | grep -q "Linking from run-time image enabled"); then - JMOD_PATHS="${JAVA_HOME}/jmods;${JMOD_PATHS}" - fi + if ! ${JAVA_HOME}/bin/jlink --help 2>&1 | grep -q "Linking from run-time image enabled"; then + JMOD_PATHS="${JAVA_HOME}/jmods;${JMOD_PATHS}" + fi
🧹 Nitpick comments (3)
.github/workflows/mac-dmg.yml (2)
45-46: OpenJFX 25 URL/hash update looks goodChecksumming is enforced; jmods subset extracted correctly.
Optionally centralize OpenJFX version/URL/hash across workflows to avoid drift.
80-80: Dropping -Djavafx.platform is correct; verify JDK version alignment
CI is using Java 24.0.1+9 while pom.xml targets JavaFX 25—consider updating JAVA_VERSION to 25.x in your mac-dmg.yml workflow for consistency..github/workflows/win-exe.yml (1)
29-30: OpenJFX 25 URL/hash for Windows x64 looks goodChecksum verification and extraction are in place.
Consider adding curl resilience (e.g., -fL --retry 3 --retry-delay 2 --connect-timeout 30) to the download step for fewer flakey runs.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (5)
dist/linux/appimage/build.shis excluded by!**/dist/**dist/linux/debian/controlis excluded by!**/dist/**dist/linux/debian/rulesis excluded by!**/dist/**dist/mac/dmg/build.shis excluded by!**/dist/**dist/win/build.ps1is excluded by!**/dist/**
📒 Files selected for processing (10)
.github/workflows/appimage.yml(2 hunks).github/workflows/build.yml(1 hunks).github/workflows/debian.yml(2 hunks).github/workflows/mac-dmg-x64.yml(3 hunks).github/workflows/mac-dmg.yml(3 hunks).github/workflows/pullrequest.yml(1 hunks).github/workflows/release-check.yml(1 hunks).github/workflows/win-exe.yml(4 hunks).idea/misc.xml(1 hunks)pom.xml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-12-11T08:28:24.864Z
Learnt from: overheadhunter
PR: cryptomator/cryptomator#3641
File: .github/workflows/win-exe.yml:20-21
Timestamp: 2024-12-11T08:28:24.864Z
Learning: In the Cryptomator project, it's acceptable to update the JDK version (e.g., to JDK 23) while keeping the JavaFX version at an older version (e.g., JavaFX 22.0.2), as this has not caused problems in the past.
Applied to files:
pom.xml
🔇 Additional comments (4)
.github/workflows/mac-dmg.yml (1)
154-154: License generation simplification LGTMInvocation without platform property is fine and consistent with other workflows.
.github/workflows/win-exe.yml (3)
100-100: Dropping -Djavafx.platform is correct; verify CI JDK vs JFX 25Looks good. Please confirm building/packaging with JDK 24 is intended with JavaFX 25. Consider bumping CI to JDK 25 for consistency.
You can reuse the script provided in the mac workflow comment to audit pom and workflow JDK versions.
222-230: MSI license generation simplification LGTMConsistent with other workflows; no platform flag needed.
319-327: EXE license generation simplification LGTMMatches MSI step; good.
This PR updates JavaFX to version 25.
Release notes of JavaFX 25 can be found here: https://gluonhq.com/products/javafx/openjfx-25-release-notes/
Noticeable changes:
Closes #3902.