Skip to content
This repository was archived by the owner on Feb 27, 2026. It is now read-only.

Added quick version checks to risky cluster-* and config-* cmds#160

Merged
chelma merged 2 commits intomainfrom
cli-ver-warn
Jan 24, 2024
Merged

Added quick version checks to risky cluster-* and config-* cmds#160
chelma merged 2 commits intomainfrom
cli-ver-warn

Conversation

@chelma
Copy link
Collaborator

@chelma chelma commented Jan 23, 2024 •
edited
Loading

Description

  • Updated the cluster-* and config-* commands that have the potential for impact. They now check if the user's deployed Arkime Cluster is compatible with the currently CLI version, using the AWS AIO Version number.
  • I did not update the vpc-* commands with this check because that will require a backwards incompatible change (we need to embed the AWS AIO Version in an existing Param Store entry). I'll address those changes after this PR is resolved.

Tasks

Testing

  • Added unit tests
  • Tested on my laptop against my own AWS account:
(.venv) chelma@3c22fba4e266 aws-aio % ./manage_arkime.py --region us-east-1 cluster-create --name MyClusterV2
2024-01-24 07:32:52 - Debug-level logs save to file: /Users/chelma/workspace/Arkime/aws-aio/manage_arkime/manage_arkime.log
2024-01-24 07:32:52 - Using AWS Credential Profile: None
2024-01-24 07:32:52 - Using AWS Region: us-east-1
2024-01-24 07:32:53 - The AWS AIO versions of your CLI (2) and Cluster (1) do not match.  This is likely to result in unexpected behavior.  Please change your CLI to the latest minor version under the m
ajor version (2).  Check out the following README section for more details: https://github.com/arkime/aws-aio#aws-aio-version-mismatch
2024-01-24 07:32:53 - Aborting...

(.venv) chelma@3c22fba4e266 aws-aio % git ls-remote --tags git@github.com:arkime/aws-aio.git
dfef816c31674390202b9048290037686118eec4        refs/tags/v0.1.1
a1aec22ecec9825d7d3920a2ad94800f595f9fa4        refs/tags/v1.0.0
1c851b5cd553fa2d65a68239b9f89eee4bbb2b34        refs/tags/v2.0.0
e679663ab65488802881cc7c7171c45903449a1d        refs/tags/v2.1.0
6c70ed45a4d59eae69d8ce0a85c284ad56fc2fa2        refs/tags/v2.2.0

License

I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@chelma
Added quick version checks to risky cluster-* and config-* cmds
2e46eee 
Signed-off-by: Chris Helma <chelma+github@amazon.com>
@chelma chelma added the enhancement New feature or request label Jan 23, 2024
@chelma chelma requested a review from awick January 23, 2024 20:52
@chelma
README Update; fix for cluster-destroy
85d6ce9 
Signed-off-by: Chris Helma <chelma+github@amazon.com>
@chelma chelma merged commit 136f70a into main Jan 24, 2024
@chelma chelma deleted the cli-ver-warn branch January 24, 2024 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@awick awick awick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chelma @awick