fix: login error when github account does not have display name#165
Merged
antoinejaussoin merged 3 commits intoantoinejaussoin:developfrom Nov 9, 2020
Merged
fix: login error when github account does not have display name#165antoinejaussoin merged 3 commits intoantoinejaussoin:developfrom
antoinejaussoin merged 3 commits intoantoinejaussoin:developfrom
Conversation
Contributor
Author
|
Close for wrong logic. Will fix in next pull request |
Contributor
Author
|
Reopen after fixing logic |
antoinejaussoin
approved these changes
Nov 9, 2020
Owner
|
Thank you so much for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Github account without name to log in the application. Server thows an error like this. I fixed this issue by check if that account has name or not then set default name.
Account can log in:
Account can NOT login:
