Remove usage of MainDispatcherRule in PagingDataDifferTest#562
Closed
veyndan wants to merge 2 commits intoandroidx:androidx-mainfrom
Closed
Remove usage of MainDispatcherRule in PagingDataDifferTest#562veyndan wants to merge 2 commits intoandroidx:androidx-mainfrom
veyndan wants to merge 2 commits intoandroidx:androidx-mainfrom
Conversation
Member
|
|
claraf3
reviewed
Jun 6, 2023
| pagingSourceFactory = { | ||
| TestPagingSource( | ||
| loadDelay = 1000, | ||
| loadContext = coroutineContext, |
Member
There was a problem hiding this comment.
I think we no longer need to set loadContext here
Contributor
Author
There was a problem hiding this comment.
Ooo nice, just removed it in the latest commit!
5e44def to
00f6b6b
Compare
claraf3
approved these changes
Jun 12, 2023
Member
|
Hi @veyndan there are merge conflicts on this PR, probably because I had just merged in the other PRs. Can you please try rebasing this? |
00f6b6b to
1f5051a
Compare
Contributor
Author
|
Rebased! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opted to just pass in an
EmptyCoroutineContexttoPagingDataDifferinstead of inliningMainDispathcherRule, as it's clearer to follow. The removal ofloadDispatcherwas necessary for this to pass. I didn't trace why this had to be removed, but imo it makes the tests easier to read.Test: ./gradlew test connectedCheck
Bug: 270612487