Update to winit-0.31.0-beta.2 by kchibisov · Pull Request #8750 · alacritty/alacritty

kchibisov · 2025-11-16T08:31:35Z

No description provided.

alacritty/src/config/bindings.rs

chrisduerr

Always impressive to me how much winit manages to change without improving anything. The API seems to have gotten worse somehow.

alacritty/src/display/mod.rs

alacritty/src/display/window.rs

chrisduerr · 2025-11-23T18:13:50Z

alacritty/src/display/window.rs

+            },
+            #[cfg(all(feature = "wayland", not(any(target_os = "macos", windows))))]
+            RawDisplayHandle::Wayland(_) => {
+                Self::get_wayland_window(identity, window_config, activation_token)


Is it really necessary to create a window for each individual platform now? That seems like a horrible API. Wasn't the whole purpose of winit to abstract over this?

The attributes is the problem, we need platform specific attributes. Probably should rename all the function to get_platfrom_window_attributes and such.

Couldn't the attributes be generic and work for all platforms though? The default is empty anyway, why does it matter if there's a with_activation_token function on X11 if you can just not call it?

This is actually how I personally want it to be, we just starting slow, since this mechanism should be in place anyway for out-of-tree backends, but over time, we'll make extensions like that into winit-core without platform restrictions, etc.

Sounds like yet another breaking change coming up? 🥲

alacritty/src/display/window.rs

alacritty/src/event.rs

alacritty/src/input/keyboard.rs

chrisduerr · 2025-11-24T04:38:49Z

@perfbot

perfbot · 2025-11-24T04:54:33Z

kchibisov · 2025-11-24T14:34:01Z

@perfbot

perfbot · 2025-11-24T14:49:44Z

alacritty/src/display/window.rs

chrisduerr · 2025-11-25T23:34:16Z

alacritty/src/display/window.rs

+            },
+            #[cfg(all(feature = "wayland", not(any(target_os = "macos", windows))))]
+            RawDisplayHandle::Wayland(_) => {
+                Self::get_wayland_window(identity, window_config, activation_token)


Couldn't the attributes be generic and work for all platforms though? The default is empty anyway, why does it matter if there's a with_activation_token function on X11 if you can just not call it?

alacritty/src/event.rs

chrisduerr · 2025-11-25T23:43:10Z

alacritty/src/input/keyboard.rs

+                (NamedKey::Control, KeyLocation::Left) => "57442",
+                (NamedKey::Alt, KeyLocation::Left) => "57443",
+                (NamedKey::Meta, KeyLocation::Left) => "57444",
+                #[allow(deprecated)]


What's deprecated here? NamedKey::Hyper? If so, what's the alternative going to be?

We adopted keyboard types crate, which follows w3c standard when it comes to keys, etc for better inter-op with existing crates, and the thing is that Hyper and Super are deprecated in it, so this crate also follows deprecation here. While I'm not happy with it, it's what it is.

There's no alternative and it's not like they are going away. I'd maybe change it upstream to not make them deprecated, though, I have a feeling that I've already proposed something like that in the past...

So the idea is that because it's not standard people should just use key codes? It seems pretty widely used, I'm surprised there wouldn't be something for it.

I don't think any of them are used, unless you explicitly add them. there's no keyboard with them, etc, and we don't use anything other than forwarding.

there's no keyboard with them

You're not using a Space-cadet keyboard?

chrisduerr

Seems fine now, I'd just like to wait for a stable release.

chrisduerr · 2025-11-30T20:22:13Z

CHANGELOG.md


+### Added
+
+- Tablet input support.


Suggested change

- Tablet input support.

- Tablet input support

kchibisov · 2025-12-01T05:03:39Z

, I'd just like to wait for a stable release.

I generally don't want to rebase it and it also brings crossfont up to date and allows to bump some other deps. I'd say that given I decide stable release pretty much, can ensure that it won't change much wrt things that are already in the PR.

chrisduerr · 2025-12-01T10:33:53Z

I generally don't want to rebase it and it also brings crossfont up to date and allows to bump some other deps. I'd say that given I decide stable release pretty much, can ensure that it won't change much wrt things that are already in the PR.

By rebase it you mean for potential other changes in Alacritty? I think if winit is not changing and this is 'pretty much stable', then we might as well wait for a stable release because it sounds like it can't be far off. If it's not stable, then we shouldn't be merging it into master. So either way I'm not sure it makes sense to use pre-release versions (especially because we need to bump it again once it's stable).

kchibisov · 2025-12-01T10:38:11Z

If we won't touch input handling for the time until it's stable, then I'm fine. I just don't want to rebase input handling over and over and thus retesting it.

chrisduerr · 2025-12-01T11:13:00Z

If we won't touch input handling for the time until it's stable, then I'm fine. I just don't want to rebase input handling over and over and thus retesting it.

Yeah makes sense. Maybe we'll just hold this PR for now, but if we decide to work on anything else input/event-related we can just merge this first. I don't expect any external contributors to send a lot of big input-related patches.

This comment was marked as outdated.

Sign in to view

kchibisov force-pushed the update-winit-031 branch 4 times, most recently from 7df1935 to b0318f4 Compare November 22, 2025 14:07

kchibisov marked this pull request as ready for review November 22, 2025 14:09

kchibisov requested a review from chrisduerr November 22, 2025 14:09

kchibisov force-pushed the update-winit-031 branch 3 times, most recently from 1c90706 to c6aaaf0 Compare November 22, 2025 14:44

kchibisov commented Nov 22, 2025

View reviewed changes

alacritty/src/config/bindings.rs Show resolved Hide resolved

chrisduerr requested changes Nov 23, 2025

View reviewed changes

kchibisov force-pushed the update-winit-031 branch 3 times, most recently from 20f6734 to 145d8cb Compare November 24, 2025 04:41

kchibisov force-pushed the update-winit-031 branch from 145d8cb to d00ebf6 Compare November 24, 2025 14:33

kchibisov requested a review from chrisduerr November 24, 2025 14:34

kchibisov force-pushed the update-winit-031 branch from d00ebf6 to 516e785 Compare November 24, 2025 14:43

kchibisov force-pushed the update-winit-031 branch from 516e785 to b9bb2b6 Compare November 25, 2025 08:59

chrisduerr requested changes Nov 25, 2025

View reviewed changes

kchibisov force-pushed the update-winit-031 branch from b9bb2b6 to 76d43e4 Compare November 26, 2025 06:07

kchibisov requested a review from chrisduerr November 27, 2025 09:46

kchibisov force-pushed the update-winit-031 branch 3 times, most recently from c1cb283 to b79d663 Compare November 30, 2025 13:18

kchibisov mentioned this pull request Nov 30, 2025

Memory leak in daemon mode #8769

Closed

chrisduerr requested changes Nov 30, 2025

View reviewed changes

CHANGELOG.md

### Added

- Tablet input support.

Copy link

Member

chrisduerr Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

- Tablet input support.

- Tablet input support

kchibisov added 2 commits December 25, 2025 23:43

Update to winit-0.31.0-beta.2

d1feb04

v2

3473acb

kchibisov force-pushed the update-winit-031 branch from b79d663 to 3473acb Compare December 25, 2025 14:43

Conversation

kchibisov commented Nov 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

chrisduerr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chrisduerr commented Nov 24, 2025

Uh oh!

perfbot commented Nov 24, 2025

Uh oh!

kchibisov commented Nov 24, 2025

Uh oh!

perfbot commented Nov 24, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chrisduerr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kchibisov commented Dec 1, 2025

Uh oh!

chrisduerr commented Dec 1, 2025

Uh oh!

kchibisov commented Dec 1, 2025

Uh oh!

chrisduerr commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

kchibisov commented Nov 16, 2025 •

edited

Loading

chrisduerr commented Dec 1, 2025 •

edited

Loading