Skip to content

update install script with lates mmdet dist to fix yolox input size i…#1123

Open
fabiogeraci wants to merge 1 commit intoairctic:masterfrom
fabiogeraci:install_script
Open

update install script with lates mmdet dist to fix yolox input size i…#1123
fabiogeraci wants to merge 1 commit intoairctic:masterfrom
fabiogeraci:install_script

Conversation

@fabiogeraci
Copy link

I modified the install script in order to fix the input_size issue with yolox, as pointed out by @dnth

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #1123 (aa9a4f3) into master (356d29b) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1123      +/-   ##
==========================================
- Coverage   85.48%   85.28%   -0.20%     
==========================================
  Files         305      305              
  Lines        6675     6675              
==========================================
- Hits         5706     5693      -13     
- Misses        969      982      +13     
Flag Coverage Δ
unittests 85.28% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
icevision/models/inference_sahi.py 81.44% <0.00%> (-13.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 356d29b...aa9a4f3. Read the comment docs.

@dnth
Copy link
Contributor

dnth commented Jul 19, 2022

Hi @fabiogeraci we've been wanting to upgrade the mmdet to 2.20.0 for a very long time now.. This change however breaks another model from mmdet (VFNet). Since there are many IceVision users who relied on VFNet we were reluctant to make this change.

We are now planning for an upgrade that will include this and will be out very soon! Thank you again for submitting this PR.

@fabiogeraci
Copy link
Author

Thanks for the reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants