fix(eslint-plugin-query): add ESLint v10 to peerDependencies#10152
fix(eslint-plugin-query): add ESLint v10 to peerDependencies#10152mixelburg wants to merge 2 commits intoTanStack:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 2ede4fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated eslint-plugin-query to add ESLint v10 to its peer dependency range and bumped Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/eslint-plugin-query/package.json (1)
62-63:⚠️ Potential issue | 🟠 Major
@typescript-eslint/utils ^8.48.0does not declare ESLint v10 compatibility in its peerDependencies.typescript-eslint v8.56.0 (released Feb 16, 2026) added code-level support for ESLint v10, but its
peerDependencies.eslintstill declares only^8.57.0 || ^9.0.0. This means npm and pnpm will emit an unmet peerDependency warning when pairing this package with ESLint v10, even though the code technically supports it.A follow-up release from typescript-eslint (v8.57.0 or later) that updates the eslint peerDependency range to include
^10.0.0is needed to fully resolve this. Until then, the dependency will produce warnings in ESLint v10 environments.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/eslint-plugin-query/package.json` around lines 62 - 63, Update the `@typescript-eslint/utils` dependency in package.json (the "@typescript-eslint/utils" entry) to a version >= 8.57.0 (for example "^8.57.0") so the typescript-eslint package includes ESLint v10 in its peerDependencies and avoids peer dependency warnings in ESLint v10 environments; modify the version string for "@typescript-eslint/utils" accordingly and run install to verify no peerDependency warnings remain.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/eslint-plugin-query/package.json`:
- Around line 62-63: Update the `@typescript-eslint/utils` dependency in
package.json (the "@typescript-eslint/utils" entry) to a version >= 8.57.0 (for
example "^8.57.0") so the typescript-eslint package includes ESLint v10 in its
peerDependencies and avoids peer dependency warnings in ESLint v10 environments;
modify the version string for "@typescript-eslint/utils" accordingly and run
install to verify no peerDependency warnings remain.
Adds ESLint v10 to the supported
peerDependenciesrange for@tanstack/eslint-plugin-query.ESLint v10 was released recently and the plugin is compatible — it doesn't use any of the removed/deprecated APIs (
FlatESLint,LegacyESLint,eslintrcconfig format). All existing tests pass without changes.Resolves #10141
Summary by CodeRabbit