Skip to content

fix: Prevent message sending to archived rooms via API#38653

Merged
ggazzo merged 7 commits intodevelopfrom
copilot/fix-sendmessage-archive-flag
Feb 13, 2026
Merged

fix: Prevent message sending to archived rooms via API#38653
ggazzo merged 7 commits intodevelopfrom
copilot/fix-sendmessage-archive-flag

Conversation

Copy link
Contributor

Copilot AI commented Feb 13, 2026

Fix: Prevent sending messages to archived rooms

Task: ARCH-1956

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 13, 2026

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2026

🦋 Changeset detected

Latest commit: 2ec7075

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/abac Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI and others added 4 commits February 13, 2026 14:19
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix SendMessage to check archived-flag before sending Fix: Prevent sending messages to archived rooms via API Feb 13, 2026
Copilot AI requested a review from ggazzo February 13, 2026 14:27
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.44%. Comparing base (3b003e6) to head (0aed734).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #38653      +/-   ##
===========================================
- Coverage    70.46%   70.44%   -0.03%     
===========================================
  Files         3174     3174              
  Lines       111075   111077       +2     
  Branches     20030    20019      -11     
===========================================
- Hits         78268    78246      -22     
- Misses       30759    30784      +25     
+ Partials      2048     2047       -1     
Flag Coverage Δ
e2e 60.41% <ø> (-0.04%) ⬇️
e2e-api 47.69% <ø> (-1.04%) ⬇️
unit 71.42% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.1GiB 1.1GiB +11MiB
rocketchat 360MiB 349MiB +11MiB
omnichannel-transcript-service 134MiB 134MiB -168B
queue-worker-service 134MiB 134MiB -502B
ddp-streamer-service 128MiB 128MiB +513B
account-service 115MiB 115MiB -801B
authorization-service 112MiB 112MiB +886B
presence-service 112MiB 112MiB -3.4KiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "02/12 22:57", "02/13 14:09", "02/13 14:51 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
Loading

Statistics (last 30 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.4GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.1GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-38653
  • Baseline: develop
  • Timestamp: 2026-02-13 14:51:09 UTC
  • Historical data points: 30

Updated: Fri, 13 Feb 2026 14:51:10 GMT

@ggazzo ggazzo changed the title Fix: Prevent sending messages to archived rooms via API fix: Prevent sending messages to archived rooms via API Feb 13, 2026
@ggazzo ggazzo added this to the 8.2.0 milestone Feb 13, 2026
@ggazzo ggazzo marked this pull request as ready for review February 13, 2026 15:14
@ggazzo ggazzo requested a review from a team as a code owner February 13, 2026 15:14
@ggazzo
Copy link
Member

ggazzo commented Feb 13, 2026

/jira ARCH

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Copilot AI changed the title fix: Prevent sending messages to archived rooms via API Fix: Prevent message sending to archived rooms via API Feb 13, 2026
@ggazzo ggazzo changed the title Fix: Prevent message sending to archived rooms via API fix: Prevent message sending to archived rooms via API Feb 13, 2026
@ggazzo
Copy link
Member

ggazzo commented Feb 13, 2026

/jira ARCH-1935

Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com>
@ggazzo
Copy link
Member

ggazzo commented Feb 13, 2026

/jira ARCH-1935

1 similar comment
@ggazzo
Copy link
Member

ggazzo commented Feb 13, 2026

/jira ARCH-1935

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Feb 13, 2026
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 13, 2026
@ggazzo ggazzo merged commit cb3e570 into develop Feb 13, 2026
10 checks passed
@ggazzo ggazzo deleted the copilot/fix-sendmessage-archive-flag branch February 13, 2026 18:50
TheRazorbill pushed a commit to TheRazorbill/Rocket.Chat that referenced this pull request Feb 20, 2026
)

Co-authored-by: ggazzo <guilherme@gazzo.xyz>
Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants