Conversation
3f58fbc to
fa2d9b8
Compare
|
I've verified that |
Co-authored-by: roger <octeep@pm.me>
|
I'm facing this issue ArniDagur/python-adblock#36. I though it would be cleared with your patches though it still persists. What do you think is causing this? On |
I'm not sure, can you list the steps to reproduce the issue? |
The Makefile for this in ports is attached, only thing worth looking there in are the crates used while compiling. And the build command is: But if you have a OpenBSD machine and know how to use ports, try jasperla/openbsd-wip, I've recently commited the ports as devel/maturin and www/py-adblock. |
|
I've reproduce the issue with just |
|
Are you using the ports system? Or downloading the binaries? There is no hope with binary packages. But with ports edit Makefile in lang/rust to have |
|
@Dkarama I was able to get tests pass with pyo3 git main branch code. Try patch python-adblock's [patch.crates-io]
pyo3 = { git = "https://github.com/PyO3/pyo3.git", rev = "7ac75366c27d5be6cc8fd5b344da1953c12d2c3e" } |
|
Did you patch something else? The latest HEAD on python-adblock fails with to compile your changes to |
|
Just remove the rust_2018_idioms lint. |
Closes #469
cc @octeep